feat(argo-rollouts): Restrict write access to rollout status in the aggregated roles #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregated roles Signed-off-by: Nedal Eskaif <[email protected]>
nedal87
force-pushed
the
feat/neskaif/restrict-rollout-status-write-access
branch
from
503d009
to
920204e
Compare
yu-croco
reviewed
Feb 24, 2024
| @@ -37,7 +37,6 @@ rules: | |||
| resources: | |||
| - rollouts | |||
| - rollouts/scale | |||
| - rollouts/status | |||
There was a problem hiding this comment.
Thank you for your PR.
Since upstream has the permission in latest version, so can you please fix upstream at first ?
*argo-helm follows upstream's manifest.
https://github.com/argoproj/argo-rollouts/blob/v1.6.6/manifests/base/argo-rollouts-aggregate-roles.yaml
There was a problem hiding this comment.
Hi @yu-croco sure thing, I will open a PR in upstream. Thanks!
yu-croco
added
the
awaiting-upstream
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
yu-croco
added
the
on-hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status subresource is typically managed automatically by the controller managing the resource, in this case, the Argo Rollouts controller. Allowing users to directly manipulate the status subresource could lead to inconsistencies and unintended behavior, as the controller might overwrite or ignore manually set status updates.
Therefore, it's generally a good practice to restrict permissions to modify the status subresource to the controller or system components responsible for managing the resource, rather than granting such permissions to users directly. This helps ensure the integrity and consistency of the resource's state.
After this change, users will be still able to view the rollout status.
Current setup: argo-rollouts:edit
Checklist: